Skip to content

OKD-322: Update Dockerfile to work on CentOS/RHEL 10#500

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
jatinsu:cs10-fix
Apr 9, 2026
Merged

OKD-322: Update Dockerfile to work on CentOS/RHEL 10#500
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
jatinsu:cs10-fix

Conversation

@jatinsu
Copy link
Copy Markdown
Contributor

@jatinsu jatinsu commented Feb 23, 2026

Starting with version OKD version 4.22, we are attempting to use CentOS 10 base images. The builder fails to build on CentOS 10 since runc isn't a available package on CentOS 10. For more context this is the build log (Red Hat VPN required to view the build log)

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 23, 2026 •
edited by openshift-ci bot
Loading

@jatinsu: This pull request references OKD-322 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Starting with version OKD version 4.22, we are attempting to use CentOS 10 base images. The builder fails to build on CentOS 10 since runc isn't a available package on CentOS 10. For more context this is the build log (Red Hat VPN required to view the build log)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 23, 2026
@jatinsu
Copy link
Copy Markdown
Contributor Author

jatinsu commented Feb 24, 2026

/retest-required

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 3, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9ee34edf-f18c-4e18-a796-9254e222dac2

📥 Commits

Reviewing files that changed from the base of the PR and between 711f2e6 and da4306a.

📒 Files selected for processing (1)
  • Dockerfile.rhel8

Walkthrough

The Dockerfile.rhel8 was modified to dynamically select the container runtime package at build time. The build step now sources /etc/os-release, conditionally sets CONTAINER_RUNTIME to either runc or crun based on platform identifier, and installs the selected runtime instead of the previously hardcoded runc package.

Changes

Cohort / File(s) Summary
Dockerfile Build Configuration
Dockerfile.rhel8		 Modified the RUN command to source /etc/os-release, initialize CONTAINER_RUNTIME to runc, conditionally override to crun when PLATFORM_ID indicates platform:el10, and install the dynamically selected runtime package via variable substitution instead of hardcoded package name.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 3, 2026

@jatinsu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security da4306a link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@prabhapa
Copy link
Copy Markdown
Contributor

prabhapa commented Apr 9, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jatinsu, prabhapa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2026
@prabhapa
Copy link
Copy Markdown
Contributor

prabhapa commented Apr 9, 2026

/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Apr 9, 2026
@prabhapa
Copy link
Copy Markdown
Contributor

prabhapa commented Apr 9, 2026

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 9, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 9, 2026

@prabhapa: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit fcd4ce2 into openshift:main Apr 9, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@divyansh42 divyansh42 Awaiting requested review from divyansh42

@sayan-biswas sayan-biswas Awaiting requested review from sayan-biswas

Assignees

@prabhapa prabhapa

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jatinsu @openshift-ci-robot @prabhapa